Add Counters to QuasiNewtonNLPModels#122
Closed
MaxenceGollier wants to merge 8 commits into
Closed
Conversation
Member
|
@MaxenceGollier thanks for the PR. Instead of adding manually counters to all structures. Would it be sufficient to add |
Contributor
|
Author
|
What do you think of this solution @tmigot ? |
tmigot
requested changes
Jul 25, 2024
tmigot
left a comment
tmigot
left a comment
Member
There was a problem hiding this comment.
Thanks @MaxenceGollier ! I suggest we don't throw away this PR, but use it to add unit tests on counters (that will be valid for the next NLPModels release).
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
dpo
requested changes
Oct 28, 2024
Co-authored-by: Dominique <dominique.orban@gmail.com>
Member
|
@MaxenceGollier All tests are failing here. |
Member
|
@MaxenceGollier Is this still relevant? I feel the unit tests that you added are already tested in NLPModels.jl (in the |
Author
|
I don't think it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #121